jhtimmins commented on a change in pull request #11189:
URL: https://github.com/apache/airflow/pull/11189#discussion_r503358854
##########
File path: airflow/www/security.py
##########
@@ -377,13 +406,13 @@ def has_all_dags_access(self):
"""
Has all the dag access in any of the 3 cases:
1. Role needs to be in (Admin, Viewer, User, Op).
- 2. Has can_dag_read permission on all_dags view.
- 3. Has can_dag_edit permission on all_dags view.
+ 2. Has can_read permission on dags view.
+ 3. Has can_edit permission on dags view.
Review comment:
Yeah permissions should be refactored/simplified in general, but I've
been avoiding that as much as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
