jhtimmins commented on a change in pull request #11189:
URL: https://github.com/apache/airflow/pull/11189#discussion_r503368529
##########
File path: airflow/api_connexion/security.py
##########
@@ -54,7 +55,7 @@ def check_authorization(
return
appbuilder = current_app.appbuilder
for permission in permissions:
- if permission in (('can_read', 'Dag'), ('can_edit', 'Dag')):
+ if permission in (('can_read', RESOURCE_ALL_DAGS), ('can_edit',
RESOURCE_ALL_DAGS)):
Review comment:
So you're suggesting that the backend permission be `AllDags`, but on
the views its `Dag`? That feels dicey. How would you feel about access to
`Dags` as resource name? Allows the possibility of multiple Dags, but without
overly emphasizing the `All` aspect of it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
