aaltay commented on a change in pull request #11375:
URL: https://github.com/apache/airflow/pull/11375#discussion_r505734734
##########
File path: airflow/providers/google/cloud/hooks/dataflow.py
##########
@@ -98,13 +98,13 @@ class DataflowJobStatus:
Helper class with Dataflow job statuses.
"""
- JOB_STATE_DONE = "JOB_STATE_DONE"
- JOB_STATE_RUNNING = "JOB_STATE_RUNNING"
- JOB_STATE_FAILED = "JOB_STATE_FAILED"
- JOB_STATE_CANCELLED = "JOB_STATE_CANCELLED"
- JOB_STATE_PENDING = "JOB_STATE_PENDING"
- FAILED_END_STATES = {JOB_STATE_FAILED, JOB_STATE_CANCELLED}
- SUCCEEDED_END_STATES = {JOB_STATE_DONE}
+ DONE = "DONE"
Review comment:
Do you still need to keep the values in the `JOB_STATE_DONE` format to
match Dataflow returned statuses?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
