ashb commented on a change in pull request #11589:
URL: https://github.com/apache/airflow/pull/11589#discussion_r506969739
##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -1664,42 +1664,11 @@ def _schedule_dag_run(self, dag_run: DagRun,
currently_active_runs: int, session
self._send_dag_callbacks_to_processor(dag_run, callback_to_run)
- # Get list of TIs that do not need to executed, these are
- # tasks using DummyOperator and without on_execute_callback /
on_success_callback
- dummy_tis = [
- ti for ti in schedulable_tis
- if
- (
- ti.task.task_type == "DummyOperator"
- and not ti.task.on_execute_callback
- and not ti.task.on_success_callback
- )
- ]
-
# This will do one query per dag run. We "could" build up a complex
Review comment:
This comment doesn't make sense when called on a (instance) method on
DagRun, as that almost by definition only operators on a single dag run. The
comment is kept here in the scheduler because that's where might think we want
to batch the queries up, but shouldn't.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
