vshshjn7 commented on a change in pull request #11318:
URL: https://github.com/apache/airflow/pull/11318#discussion_r508354923
##########
File path: airflow/providers/google/cloud/transfers/sql_to_gcs.py
##########
@@ -232,6 +232,10 @@ def _write_local_data_files(self, cursor):
return files_to_upload
+ def get_cursor_iterator(self, cursor):
Review comment:
I was looking at `_PrestoToGCSPrestoCursorAdapter` code, it looks like
the whole cursor code is copied from [presto
code](https://github.com/prestodb/presto-python-client/blob/master/prestodb/dbapi.py#L170).
I am afraid if we do the same, then in the future, for some reason, logic
changes, then we will also have to change the logic at our end also. Isn't that
overhead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
