ashb commented on a change in pull request #11592:
URL: https://github.com/apache/airflow/pull/11592#discussion_r508465859



##########
File path: tests/www/test_decorators.py
##########
@@ -0,0 +1,28 @@
+from airflow.www import app
+from airflow.www.decorators import has_dag_access
+from flask_appbuilder import BaseView
+from unittest import TestCase
+from mock import Mock
+
+
+class TestDecorators(TestCase):

Review comment:
       ```suggestion
   class TestDecorators:
   ```
   
   With pytest being used now we don't need to inherit from TestCase anymore

##########
File path: tests/www/test_decorators.py
##########
@@ -0,0 +1,28 @@
+from airflow.www import app
+from airflow.www.decorators import has_dag_access
+from flask_appbuilder import BaseView
+from unittest import TestCase
+from mock import Mock

Review comment:
       ```suggestion
   from unittest.mock import Mock
   ```

##########
File path: tests/www/test_decorators.py
##########
@@ -0,0 +1,28 @@
+from airflow.www import app
+from airflow.www.decorators import has_dag_access
+from flask_appbuilder import BaseView
+from unittest import TestCase

Review comment:
       ```suggestion
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to