mik-laj commented on a change in pull request #11736:
URL: https://github.com/apache/airflow/pull/11736#discussion_r510416587
##########
File path: airflow/providers/hashicorp/secrets/vault.py
##########
@@ -112,7 +112,7 @@ class VaultBackend(BaseSecretsBackend, LoggingMixin):
def __init__( # pylint: disable=too-many-arguments
self,
connections_path: str = 'connections',
- variables_path: str = 'variables',
+ variables_path: Optional[str] = None,
Review comment:
@fhoda We can change this default value, but we have to do it safely for
the end user. We shoul have at least one [minor version](https://semver.org/)
that has a warning about changing default value in a future version -
[FutureWarning](https://docs.python.org/3/library/exceptions.html#FutureWarning).
However, this can now be difficult to do if this class is in the backport
provider for Airflow 1.10, provider package for Airflow 2.0. Each package has a
separate release cadence, so It is not easy for us to find one version where we
can inject this warning outside of the normal publishing cycle.
It would be a lot easier if this change happened in the core. Then we can
accept these changes into the 2.0 series, and then add an additional warning to
the 1.10 series.
So I propose that in this release you add a warning about changing the
default value in a future release. When we release Airflow 2.1 (or when there
is another good time) we will introduce the breaking changes proposed by you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
