mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r511213269
##########
File path: scripts/ci/kubernetes/ci_run_helm_testing.sh
##########
@@ -18,7 +18,28 @@
echo "Running helm tests"
+. "$( dirname "${BASH_SOURCE[0]}" )/../libraries/_script_init.sh"
+
+if [[ -f "${BUILD_CACHE_DIR}/.skip_tests" ]]; then
+ echo
+ echo "Skip tests"
+ echo
+ exit
+fi
+
+build_images::prepare_ci_build
+
+build_images::rebuild_ci_image_if_needed
+kind::make_sure_kubernetes_tools_are_installed
+
+
+python -m pip install pytest kubernetes \
Review comment:
I am concerned that we will be able to achieve a selective selection of
tests based on directories, if we do not have a unified setup. Now we will only
be able to run the Chart tests if there are changes to Chart only. This will
greatly reduce the frequency of running these tests.
The ability to run in Breeze will also facilitate contributions by new
contributors. They will be able to run the tests very easily via ``breeze tests
-- /chart/tests/``.
While I'm not sure about the first part, we should definitely support
running the tests in Breeze. This shouldn't be difficult as we just need Helm
to have Docker installed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
