mik-laj commented on a change in pull request #11693:
URL: https://github.com/apache/airflow/pull/11693#discussion_r511222593
##########
File path: scripts/ci/kubernetes/ci_run_helm_testing.sh
##########
@@ -18,7 +18,28 @@
echo "Running helm tests"
+. "$( dirname "${BASH_SOURCE[0]}" )/../libraries/_script_init.sh"
+
+if [[ -f "${BUILD_CACHE_DIR}/.skip_tests" ]]; then
+ echo
+ echo "Skip tests"
+ echo
+ exit
+fi
+
+build_images::prepare_ci_build
+
+build_images::rebuild_ci_image_if_needed
+kind::make_sure_kubernetes_tools_are_installed
+
+
+python -m pip install pytest kubernetes \
Review comment:
When I did following changes:
```diff
Author: Kamil BreguĊa <[email protected]>
Date: Sat Oct 24 03:00:24 2020 +0200
Add Helm to dockerfile
diff --git a/Dockerfile.ci b/Dockerfile.ci
index e352bedc3..e2528f748 100644
--- a/Dockerfile.ci
+++ b/Dockerfile.ci
@@ -215,6 +215,14 @@ RUN mkdir -p /opt/bats/lib/bats-file \
RUN echo "export PATH=/opt/bats/bin:${PATH}" >> /root/.bashrc
+# Install HElm
+ARG HELM_VERSION="v3.2.4"
+
+RUN SYSTEM=$(uname -s | tr '[:upper:]' '[:lower:]') \
+ &&
HELM_URL="https://get.helm.sh/helm-${HELM_VERSION}-${SYSTEM}-amd64.tar.gz"; \
+ && curl --location ${HELM_URL} | tar -xvz -O ${SYSTEM}-amd64/helm >
/usr/local/bin/helm \
+ && chmod +x /usr/local/bin/helm
+
# Additional scripts for managing BATS addons
COPY scripts/docker/load.bash /opt/bats/lib/
RUN chmod a+x /opt/bats/lib/load.bash
```
I was able to run the tests with one command:
```
./breeze tests -- chart/tests
```
This is my perfect workflow. I don't need to know any additional commands
to run these tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
