mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract 
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r265942801
 
 

 ##########
 File path: airflow/www/templates/airflow/gantt.html
 ##########
 @@ -23,6 +23,9 @@
     
href="{{url_for('appbuilder.static',filename='datepicker/bootstrap-datepicker.css')}}"
 >
 <link type="text/css" href="{{ url_for('static', filename='css/gantt.css') }}" 
rel="stylesheet" />
 <link type="text/css" href="{{ url_for('static', filename='css/tree.css') }}" 
rel="stylesheet" />
+  <meta name="dag-id" content="{{ dag.dag_id }}">
+  <meta name="data" content="{{ data }}">
 
 Review comment:
   There is no consequence in any file. I plan to improve it in the next 
change. Now there is no consistency, so you can not afford it.
   
   Everything is displayed correctly. Jinja is intelligent enough to read our 
intentions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to