mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r267585002
##########
File path: airflow/www/templates/airflow/dag.html
##########
@@ -290,6 +294,7 @@ <h4 class="modal-title" id="dagModalLabel">
{% endblock %}
{% block tail %}
{{ super() }}
+ <script src="{{ url_for_asset('utils.js') }}"></script>
Review comment:
I guess you would like me to apply a solution similar to that presented in
the PR #4950 but this is not in my opinion the right solution. This creates one
big file that contains the major part of JS code. I would like to divide the
code into smaller parts and mark the requirements for each JS snippet to make
future refactorations easier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
