mjpieters commented on issue #12090:
URL: https://github.com/apache/airflow/issues/12090#issuecomment-721719841


   The `shutdown()` call was added [in this pull 
request](https://github.com/apache/airflow/pull/3259). I don't know if this 
still applies in Airflow 2.0.0, but I'm of the opinion that any logging 
shutdown should only be done when the process exits. It should not be up to 
`task_command.task_run()` to assume it is only ever used as a top-level call.
   
   In other words, if a `logging.shutdown()` call is necessary when, say, a 
forked child is about to exit, then the code triggering the exit should call 
`logging.shutdown()` just before it calls `os._exit()`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to