mjpieters commented on issue #12090: URL: https://github.com/apache/airflow/issues/12090#issuecomment-721721603
I found [this review remark](https://github.com/apache/airflow/pull/3259#discussion_r184536876): > I removed this line in the Elasticsearch commit (because I saw this method registered in atexit()) and it causes NoneType error. My theory is that logging.shutdown() called in atexit() need settings.Session() to be defined but at the point it was called according to the order exit functions were registered, the orm was disposed. Explicitly calling it here is safe as all the task handler have logic prevent duplicate close() calls. The correct fix would have been to fix the logger that requires a live session object, rather than shut down all logging. Barring that, only shut down the handler that causes the problems, not all logging. What exactly was causing a `NoneType` error at exit there, do you remember, @KevinYang21? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
