turbaszek commented on a change in pull request #12091:
URL: https://github.com/apache/airflow/pull/12091#discussion_r517443592
##########
File path: airflow/configuration.py
##########
@@ -70,17 +68,15 @@ def expand_env_var(env_var):
def run_command(command):
"""Runs command and returns stdout"""
process = subprocess.Popen(
- shlex.split(command),
- stdout=subprocess.PIPE,
- stderr=subprocess.PIPE,
- close_fds=True)
- output, stderr = [stream.decode(sys.getdefaultencoding(), 'ignore')
- for stream in process.communicate()]
+ shlex.split(command), stdout=subprocess.PIPE, stderr=subprocess.PIPE,
close_fds=True
+ )
+ output, stderr = [stream.decode(sys.getdefaultencoding(), 'ignore') for
stream in process.communicate()]
if process.returncode != 0:
raise AirflowConfigException(
- "Cannot execute {}. Error code is: {}. Output: {}, Stderr: {}"
- .format(command, process.returncode, output, stderr)
+ "Cannot execute {}. Error code is: {}. Output: {}, Stderr:
{}".format(
Review comment:
Should it be f-string?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
