mik-laj commented on a change in pull request #12091:
URL: https://github.com/apache/airflow/pull/12091#discussion_r517460980
##########
File path: airflow/configuration.py
##########
@@ -336,17 +338,14 @@ def get(self, section, key, **kwargs):
def _get_option_from_default_config(self, section, key, **kwargs):
# ...then the default config
if self.airflow_defaults.has_option(section, key) or 'fallback' in
kwargs:
- return expand_env_var(
- self.airflow_defaults.get(section, key, **kwargs))
+ return expand_env_var(self.airflow_defaults.get(section, key,
**kwargs))
else:
- log.warning(
- "section/key [%s/%s] not found in config", section, key
- )
+ log.warning("section/key [%s/%s] not found in config", section,
key)
raise AirflowConfigException(
- "section/key [{section}/{key}] not found "
- "in config".format(section=section, key=key))
+ "section/key [{section}/{key}] not found " "in
config".format(section=section, key=key)
Review comment:
Fixed.
https://github.com/apache/airflow/pull/12091/commits/0ec21f5ae68b438185f086eeb7872e6185f7b1c1
##########
File path: airflow/configuration.py
##########
@@ -229,21 +225,27 @@ def _validate_config_dependencies(self):
Validate that config values aren't invalid given other config values
or system-level limitations and requirements.
"""
- if (
- self.get("core", "executor") not in ('DebugExecutor',
'SequentialExecutor') and
- "sqlite" in self.get('core', 'sql_alchemy_conn')):
+ is_executor_without_sqlie_support = self.get("core", "executor") not
in (
+ 'DebugExecutor',
+ 'SequentialExecutor',
+ )
+ is_sqlite = "sqlite" in self.get('core', 'sql_alchemy_conn')
+ if is_executor_without_sqlie_support and is_sqlite:
Review comment:
Fixed.
https://github.com/apache/airflow/pull/12091/commits/0ec21f5ae68b438185f086eeb7872e6185f7b1c1
##########
File path: airflow/configuration.py
##########
@@ -229,21 +225,27 @@ def _validate_config_dependencies(self):
Validate that config values aren't invalid given other config values
or system-level limitations and requirements.
"""
- if (
- self.get("core", "executor") not in ('DebugExecutor',
'SequentialExecutor') and
- "sqlite" in self.get('core', 'sql_alchemy_conn')):
+ is_executor_without_sqlie_support = self.get("core", "executor") not
in (
Review comment:
Fixed.
https://github.com/apache/airflow/pull/12091/commits/0ec21f5ae68b438185f086eeb7872e6185f7b1c1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
