potiuk commented on a change in pull request #4543: [AIRFLOW-3718] [WIP]
Multi-layered version of the docker image
URL: https://github.com/apache/airflow/pull/4543#discussion_r266353967
##########
File path: setup.py
##########
@@ -69,7 +71,8 @@ def finalize_options(self):
pass
def run(self):
- os.system('rm -vrf ./build ./dist ./*.pyc ./*.tgz ./*.egg-info')
+ os.system('./docker_build.sh')
Review comment:
I will keep it open. I am not sure what you think about it @fokko - but I
think we have to limit the tests run via `python setup.py test` to only "real"
unit tests - i.e. those that do not require external dependencies. I am not
sure if we want to do it now or rather as separate PR though. Or maybe we
should run the whole suite of tests (in which case using Docker compose for
that might seem like a good idea).
I would like to understand how `python setup.py test` is actually used now?
Is it part of the release process to run it and prerequisite for release to
have it green? Or maybe it's used in some other places? I haven't used it at
all so far (that's why I kind of neglected it so far). Any hints/suggestions
here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
