potiuk commented on a change in pull request #4543: [AIRFLOW-3718] [WIP]
Multi-layered version of the docker image
URL: https://github.com/apache/airflow/pull/4543#discussion_r266365214
##########
File path: hooks/build
##########
@@ -144,6 +144,14 @@ echo
# So for example 'latest-3.6' will produce PYTHON_VERSION=3.6
export PYTHON_VERSION=$(echo "${LOCAL_IMAGE}" | rev | cut -d '-' -f1 | rev )
+
+# In case of CRON jobs on Travis we run builds without cache
Review comment:
@fokko -> this will take care about daily running full build from scratch on
Travis. I think that might address a lot of your concerns regarding "will it
build from scratch". No caches are used for that build, no images are pulled
from DockerHub, it will just reinstall everything from the scratch. I guess we
can setup notification to send error messages to commit list (or maybe it will
happen automatically). This way commiters might be warned about broken
transitive dependencies without actually breaking opened pull requests (people
will continue to use "working" versions of pip dependencies from last
successfully built DockerHub master build. When it gets fixed by committers and
merged into master, it will build and new set of dependencies will be used by
everyone. I think it will work in self-healing way with minimal disruptions for
contributors and committers (and maintainers).
I scheduled daily build at my Travis CI copy and will let you know when it
runs so that you can take a look
https://travis-ci.org/potiuk/airflow
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
