potiuk commented on a change in pull request #4937: [AIRFLOW-4116] 
Multi-staging includes CI image [Step 2/3]
URL: https://github.com/apache/airflow/pull/4937#discussion_r266749916
 
 

 ##########
 File path: .dockerignore
 ##########
 @@ -0,0 +1,107 @@
+#
 
 Review comment:
   That's correct @gerardo. Unfortunately if you have dependent PRs from 
another fork, you cannot base it on one-another - that's limitation of Github. 
   
   This is one change split into three commits and Part 1 is commit 1, Part 2 
is commit 1 + commit 2, Part 3 is commit 1 + commit 2 + commit 3.  Until the 
previous is merged, I have to base my PR on master, which means that previous 
commits are included. What I suggested in the PR description (but it's not 
readily visible) is to review the last commit only. Github supports it. You can 
do it easily by clicking at the commit above - and then you will be able to see 
only changes from the last commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to