[
https://issues.apache.org/jira/browse/AIRFLOW-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796603#comment-16796603
]
ASF GitHub Bot commented on AIRFLOW-4127:
-----------------------------------------
Trollgeir commented on pull request #4945: [AIRFLOW-4127] _get_instance_view
returns instance view
URL: https://github.com/apache/airflow/pull/4945
### Jira
https://issues.apache.org/jira/browse/AIRFLOW-4127
### Description
Simple bugfix for method `_get_instance_view` that returned `current_view`
instead of an `instance_view`
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Azure Container Instance Hook _get_instance_view bug
> ----------------------------------------------------
>
> Key: AIRFLOW-4127
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4127
> Project: Apache Airflow
> Issue Type: Bug
> Components: hooks
> Affects Versions: 2.0.0
> Reporter: Asgeir Berland
> Assignee: Asgeir Berland
> Priority: Major
> Labels: easyfix
> Original Estimate: 20m
> Remaining Estimate: 20m
>
> Code:
> [https://github.com/apache/airflow/blob/master/airflow/contrib/hooks/azure_container_instance_hook.py#L116]
>
> The ".current_state" needs to be stripped from the return call in this
> method. You can easily see why if you look at line107 and line129, which
> expects an "instance_view" and not "current_state".
> {code}
> return response.containers[0].instance_view.current_state
> ->
> return response.containers[0].instance_view
> {code}
> The current state of this bug makes it impossible to poll containers for
> status which is essential to detect when they have terminated their jobs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
