[
https://issues.apache.org/jira/browse/AIRFLOW-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16798708#comment-16798708
]
ASF GitHub Bot commented on AIRFLOW-4127:
-----------------------------------------
XD-DENG commented on pull request #4945: [AIRFLOW-4127] _get_instance_view
returns instance view
URL: https://github.com/apache/airflow/pull/4945
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Azure Container Instance Hook _get_instance_view bug
> ----------------------------------------------------
>
> Key: AIRFLOW-4127
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4127
> Project: Apache Airflow
> Issue Type: Bug
> Components: hooks
> Affects Versions: 2.0.0
> Reporter: Asgeir Berland
> Assignee: Asgeir Berland
> Priority: Major
> Labels: easyfix
> Fix For: 2.0.0
>
> Original Estimate: 20m
> Remaining Estimate: 20m
>
> Code:
> [https://github.com/apache/airflow/blob/master/airflow/contrib/hooks/azure_container_instance_hook.py#L116]
>
> The ".current_state" needs to be stripped from the return call in this
> method. You can easily see why if you look at line107 and line129, which
> expects an "instance_view" and not "current_state".
> {code}
> return response.containers[0].instance_view.current_state
> ->
> return response.containers[0].instance_view
> {code}
> The current state of this bug makes it impossible to poll containers for
> status which is essential to detect when they have terminated their jobs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
