jmcarp commented on a change in pull request #4926: [AIRFLOW-4104] Add type
annotations to common classes.
URL: https://github.com/apache/airflow/pull/4926#discussion_r267148079
##########
File path: airflow/models/__init__.py
##########
@@ -2065,44 +2061,45 @@ class derived from this one results in the creation of
a task object,
@apply_defaults
def __init__(
- self,
- task_id,
- owner=configuration.conf.get('operators', 'DEFAULT_OWNER'),
- email=None,
- email_on_retry=True,
- email_on_failure=True,
- retries=0,
- retry_delay=timedelta(seconds=300),
- retry_exponential_backoff=False,
- max_retry_delay=None,
- start_date=None,
- end_date=None,
- schedule_interval=None, # not hooked as of now
- depends_on_past=False,
- wait_for_downstream=False,
- dag=None,
- params=None,
- default_args=None,
- adhoc=False,
- priority_weight=1,
- weight_rule=WeightRule.DOWNSTREAM,
- queue=configuration.conf.get('celery', 'default_queue'),
- pool=None,
- sla=None,
- execution_timeout=None,
- on_failure_callback=None,
- on_success_callback=None,
- on_retry_callback=None,
- trigger_rule=TriggerRule.ALL_SUCCESS,
- resources=None,
- run_as_user=None,
- task_concurrency=None,
- executor_config=None,
- do_xcom_push=True,
- inlets=None,
- outlets=None,
- *args,
- **kwargs):
+ self,
+ task_id, # type: str
+ owner=configuration.conf.get('operators', 'DEFAULT_OWNER'), # type:
str
+ email=None, # type: Optional[str]
+ email_on_retry=True, # type: bool
+ email_on_failure=True, # type: bool
+ retries=0, # type: int
+ retry_delay=timedelta(seconds=300), # type: timedelta
+ retry_exponential_backoff=False, # type: bool
+ max_retry_delay=None, # type: Optional[datetime]
+ start_date=None, # type: Optional[datetime]
+ end_date=None, # type: Optional[datetime]
+ schedule_interval=None, # not hooked as of now
Review comment:
Not sure! This comment was already here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
