galuszkak commented on issue #4772: [AIRFLOW-3937] KubernetesPodOperator 
support for envFrom configMapRef…
URL: https://github.com/apache/airflow/pull/4772#issuecomment-474695251
 
 
   @ashb can I understand reasoning behind that, why we want to test that now? 
None of the tests were testing output of KubernetesRequestFactory before, only 
classes like Pod/PodLauncher to check if fields there are correct. 
   
   If we want to start testing that, I believe there should be separate ticket 
to make sure we cover most of the cases of outputs of KubernetesRequestFactory 
that is actually producing what we want in every case. Because for now there 
isn't single assertion on product of that class, only abstraction on top of it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to