ashb commented on a change in pull request #12472:
URL: https://github.com/apache/airflow/pull/12472#discussion_r528657993
##########
File path: airflow/provider.yaml.schema.json
##########
@@ -167,6 +167,13 @@
"python-module"
]
}
+ },
+ "extra-links": {
+ "type": "array",
Review comment:
We can define a (basic) pattern at the schema level too:
```suggestion
"type": "array",
"uniqueItems": true,
"pattern": "^\.[a-zA-Z]+[a-zA-Z0-9.\\-]*"
```
##########
File path: airflow/providers/google/provider.yaml
##########
@@ -633,3 +633,8 @@ transfers:
- source-integration-name: Google Ads
target-integration-name: Google Cloud Storage (GCS)
python-module: airflow.providers.google.ads.transfers.ads_to_gcs
+
+extra-links:
+ - airflow.providers.google.cloud.operators.bigquery.BigQueryConsoleLink
+ -
airflow.providers.google.cloud.operators.bigquery.BigQueryConsoleIndexableLink
+ - airflow.providers.google.cloud.operators.mlengine.AIPlatformConsoleLink
Review comment:
Aren't these invalid according to the schema:
```suggestion
- .operators.bigquery.BigQueryConsoleLink
- .operators.bigquery.BigQueryConsoleIndexableLink
- .operators.mlengine.AIPlatformConsoleLink
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
