ashb commented on a change in pull request #12466:
URL: https://github.com/apache/airflow/pull/12466#discussion_r528965364
##########
File path: airflow/providers/apache/hive/hooks/hive.py
##########
@@ -78,9 +78,13 @@ class HiveCliHook(BaseHook):
:type mapred_job_name: str
"""
+ conn_name_attr = 'hive_cli_conn_id'
+ default_conn_name = 'hive_cli_default'
+ conn_type = 'hive_cli'
+
def __init__(
self,
- hive_cli_conn_id: str = "hive_cli_default",
+ hive_cli_conn_id: str = default_conn_name,
Review comment:
You might not have explicitly stated it, but this is creating a new Hook
interface.
I guess the main thing is this is opt-in, so existing sub-classes don't
suddenly break. Good point. :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
