potiuk commented on a change in pull request #12466:
URL: https://github.com/apache/airflow/pull/12466#discussion_r529497101
##########
File path: airflow/providers/apache/hive/hooks/hive.py
##########
@@ -78,9 +78,13 @@ class HiveCliHook(BaseHook):
:type mapred_job_name: str
"""
+ conn_name_attr = 'hive_cli_conn_id'
Review comment:
I fully agree. But I did not want to break the compatibility
(potentially someone could have used those values - especially the defaults.
And my goal was just to make it works for providers, not having to deal with
back-compatibility :).
There is a polish sentence I tend to use in such cases which I learned from
my friend (but it has some curse-words and rhymes, so I won't translate it here
verbatim, but it roughly translates to "consistent is better than perfect".
I fully agree constants *should* be UPPERCASE of course.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
