potiuk commented on pull request #12466: URL: https://github.com/apache/airflow/pull/12466#issuecomment-735376829
> My general complaint with this pylint check is that in general I disagree that it detects actual problems. I'll stick to my opinion that it actually detects bad "smells" in code architecture and solving them leads to nicer code that has less hidden, unnecessary dependencies and is easier to maintain as the code maintains much better "single responsibility" principle and avoids "god object" pattern. https://en.wikipedia.org/wiki/God_object. While using local imports might work, those dependencies (like in this case) are there, and make it more difficult to refactor and understand the code. But that's only my opinion not a universal truth, of course, coming from much better structured and stronger typing languages. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
