potiuk commented on a change in pull request #12466:
URL: https://github.com/apache/airflow/pull/12466#discussion_r532206730
##########
File path: airflow/plugins_manager.py
##########
@@ -30,6 +30,7 @@
import importlib_metadata
from airflow import settings
+from airflow.utils.entry_points_with_dist import entry_points_with_dist
Review comment:
That's fine, I can change it this way, no problem.
In general, my opinon is that there is nothing wrong in single
class/function per module as long as there is nothing else it is really coupled
with.
I am not sure what benefits it could bring to group independent functions in
the same module, other than accidental coupling. I prefer more files than
unnecessary, accidental coupling. And you know - the design and coupling emerge
over time and we could also rename it later (refactorings and renames are super
easy if you use IDEs).
But I agree - having both module and function the same name is bad, so if
only for that reason - happy to change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
