davlum commented on issue #4952: [AIRFLOW-4008] add envFrom for Kubernetes 
Executor
URL: https://github.com/apache/airflow/pull/4952#issuecomment-475259816
 
 
   I think the simplest move here would be to get @galuszkak PR merged first, 
and I can just work off the changes that make it into master. It's true that 
the `PodRequestFactory` was previously entirely untested, so I can see why 
@galuszkak is reluctant to have that responsibility dumped onto #4772. However, 
that is something I've started doing in this PR and could make more 
comprehensive. If #4772 gets merged I can add the unittests for 
`PodRequestFactory`, timeline being ideally before the end of the week. @ashb 
Would it be possible to get this in before 1.10.3?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to