ashb commented on a change in pull request #4895: [AIRFLOW-1526] Add dingding
hook and operator
URL: https://github.com/apache/airflow/pull/4895#discussion_r268205012
##########
File path: airflow/utils/db.py
##########
@@ -286,6 +286,13 @@ def initdb():
Connection(
conn_id='cassandra_default', conn_type='cassandra',
host='cassandra', port=9042))
+ merge_conn(
+ Connection(
+ conn_id='dingding_webhook_default', conn_type='http',
+ host='https://oapi.dingtalk.com',
Review comment:
I would probably leave the host blank in the default one as most users
won't need/want to specify it (so the Hook should default to this value, not
the connection)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
