ashb commented on a change in pull request #4895: [AIRFLOW-1526] Add dingding hook and operator URL: https://github.com/apache/airflow/pull/4895#discussion_r268204537
########## File path: airflow/contrib/operators/dingding_webhook_operator.py ########## @@ -0,0 +1,73 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from airflow.contrib.hooks.dingding_webhook_hook import DingdingWebhookHook +from airflow.operators.bash_operator import BaseOperator +from airflow.utils.decorators import apply_defaults + + +class DingdingWebhookOperator(BaseOperator): + """ + This operator allows you to post messages to Dingding use webhook. + Dingding token get from conn_id extra field ``webhook_token`` for security. + + For more message detail in + `Dingding custom bot <https://open-doc.dingtalk.com/microapp/serverapi2/qf2nxq>`_ + + :param http_conn_id: connection that has Dingding ``webhook_token`` in the extra field Review comment: I don't think this should be called `http_conn_id` - `dingding_conn_id` would be more appropriate. Additionally how about pulling the token from the password field of the connection instead? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
