dstandish commented on a change in pull request #12910:
URL: https://github.com/apache/airflow/pull/12910#discussion_r538846319
##########
File path: airflow/models/taskinstance.py
##########
@@ -773,7 +773,7 @@ def get_previous_start_date(
"""
self.log.debug("previous_start_date was called")
prev_ti = self.get_previous_ti(state=state, session=session)
- return prev_ti and prev_ti.start_date
+ return prev_ti and prev_ti.start_date and
pendulum.instance(prev_ti.start_date)
Review comment:
@kaxil please see previous comment for reasining on this change. the
issue is in test cases there is no dag run, there for no _actual_ previous ti
is retrieved; instead a new one is created _which has no start date_
so we must check not only for prev_ti but also that this ti has a start date
to fix this, we'd have to add a dag run in these two virtualenv operator
tests or something like that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
