kaxil commented on a change in pull request #12910:
URL: https://github.com/apache/airflow/pull/12910#discussion_r538851306
##########
File path: airflow/models/taskinstance.py
##########
@@ -773,7 +773,7 @@ def get_previous_start_date(
"""
self.log.debug("previous_start_date was called")
prev_ti = self.get_previous_ti(state=state, session=session)
- return prev_ti and prev_ti.start_date
+ return prev_ti and prev_ti.start_date and
pendulum.instance(prev_ti.start_date)
Review comment:
I would rather have:
```python
return prev_ti and prev_ti.start_date is not None and
pendulum.instance(prev_ti.start_date)
```
I am not sure if we need to fix test or the code, my brain is not working
right now. Looping in @ashb @turbaszek @XD-DENG for reviews
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
