XD-DENG commented on a change in pull request #4705: [AIRFLOW-3743] Unify different methods of working out AIRFLOW_HOME URL: https://github.com/apache/airflow/pull/4705#discussion_r268394295
########## File path: airflow/settings.py ########## @@ -26,13 +26,13 @@ import logging import os import pendulum - +import sys from sqlalchemy import create_engine, exc from sqlalchemy.orm import scoped_session, sessionmaker from sqlalchemy.pool import NullPool -from airflow import configuration as conf +from airflow.configuration import conf, AIRFLOW_HOME, WEBSERVER_CONFIG # NOQA F401 Review comment: If `WEBSERVER_CONFIG` is not used here in `airflow/settings.py`, why do we have to import it? Possibly I missed something? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
