kaxil commented on a change in pull request #13021:
URL: https://github.com/apache/airflow/pull/13021#discussion_r541163498
##########
File path: dev/provider_packages/prepare_provider_packages.py
##########
@@ -1598,7 +1598,9 @@ def copy_readme_and_changelog(provider_package_id: str,
backport_packages: bool)
package_format = os.environ.get("PACKAGE_FORMAT", "wheel")
print(f"Building backport package: {_provider_package} in format
${package_format}")
copy_readme_and_changelog(_provider_package, BACKPORT_PACKAGES)
- command = ["python3", "setup.py", "--version-suffix-for-pypi", suffix]
+ command = ["python3", "setup.py"]
+ if suffix != "":
+ command.extend(['egg_info', '--tag-build', suffix])
if package_format in ['sdist', 'both']:
command.append("sdist")
if package_format in ['wheel', 'both']:
Review comment:
Based on Ash's comment on
https://github.com/apache/airflow/pull/13020#discussion_r541099194, we either
need one of `egg_info` (both), `wheel` or `bdist_wheel` right?
With the above code we will have both `egg_info` and `bdist_wheel` :
```
python3 setup.py egg_info --tag-build rc1 bdist_wheel
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
