potiuk commented on a change in pull request #13021:
URL: https://github.com/apache/airflow/pull/13021#discussion_r541174366
##########
File path: dev/provider_packages/prepare_provider_packages.py
##########
@@ -1598,7 +1598,9 @@ def copy_readme_and_changelog(provider_package_id: str,
backport_packages: bool)
package_format = os.environ.get("PACKAGE_FORMAT", "wheel")
print(f"Building backport package: {_provider_package} in format
${package_format}")
copy_readme_and_changelog(_provider_package, BACKPORT_PACKAGES)
- command = ["python3", "setup.py", "--version-suffix-for-pypi", suffix]
+ command = ["python3", "setup.py"]
+ if suffix != "":
+ command.extend(['egg_info', '--tag-build', suffix])
if package_format in ['sdist', 'both']:
command.append("sdist")
if package_format in ['wheel', 'both']:
Review comment:
No no. We need `egg_info --tag-build x` and then either one or both of
(bdist_wheel, sdist).
The egg_info is really pre-requisite for both..
BUT I did found another issue with SVN rename while checking (it was only
working when `--package-format both` was specified). Fixed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
