SamWheating commented on a change in pull request #12822:
URL: https://github.com/apache/airflow/pull/12822#discussion_r541322616
##########
File path: airflow/jobs/base_job.py
##########
@@ -246,7 +246,6 @@ def run(self):
finally:
self.end_date = timezone.utcnow()
session.merge(self)
- session.commit()
Review comment:
this one is safe to remove since its the last line within a
create_session context manager, so the commit is happening right after this
anyways.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
