kaxil commented on a change in pull request #4705: [AIRFLOW-3743] Unify
different methods of working out AIRFLOW_HOME
URL: https://github.com/apache/airflow/pull/4705#discussion_r268410535
##########
File path: airflow/plugins_manager.py
##########
@@ -122,10 +122,11 @@ def is_valid_plugin(plugin_obj, existing_plugins):
return False
-plugins_folder = configuration.conf.get('core', 'plugins_folder')
-if not plugins_folder:
- plugins_folder = configuration.conf.get('core', 'airflow_home') +
'/plugins'
-plugins_folder = os.path.expanduser(plugins_folder)
+plugins_folder = configuration.conf.get(
Review comment:
Can we not add this line to settings.py and just use
`plugins_folder=settings.plugins_folder` for uniformity?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
