kaxil commented on a change in pull request #4705: [AIRFLOW-3743] Unify 
different methods of working out AIRFLOW_HOME
URL: https://github.com/apache/airflow/pull/4705#discussion_r268410453
 
 

 ##########
 File path: airflow/configuration.py
 ##########
 @@ -544,6 +544,26 @@ def parameterized_config(template):
 
 conf.read(AIRFLOW_CONFIG)
 
+if conf.has_option('core', 'AIRFLOW_HOME'):
 
 Review comment:
   I am not able to understand how we get this? I understand `conf.get('core', 
'airflow_home')` but do we get this from directly environment variable? If so, 
how is it an option in `core` section..
   
   Shouldn't it be just
   ```
   if 'AIRFLOW_HOME' in os.environ and conf.get('core', 'airflow_home'): 
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to