ashb commented on a change in pull request #4705: [AIRFLOW-3743] Unify 
different methods of working out AIRFLOW_HOME
URL: https://github.com/apache/airflow/pull/4705#discussion_r268429538
 
 

 ##########
 File path: airflow/__init__.py
 ##########
 @@ -37,9 +37,6 @@
 from airflow.models import DAG
 from airflow.exceptions import AirflowException
 
-if settings.DAGS_FOLDER not in sys.path:
 
 Review comment:
   From the commit message:
   
   > There was an import cycle form settings -> logging_config ->
   > module_loading -> settings that needed to be broken on Python 2 - so I
   > have moved all adjusting of sys.path in to the settings module
   
   So not removed from code base, but isloated to a single place at least.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to