ashb commented on a change in pull request #4705: [AIRFLOW-3743] Unify 
different methods of working out AIRFLOW_HOME
URL: https://github.com/apache/airflow/pull/4705#discussion_r268429900
 
 

 ##########
 File path: UPDATING.md
 ##########
 @@ -219,6 +219,19 @@ if foo is None:
 
 This changes the behaviour if you previously explicitly provided `None` as a 
default value. If your code expects a `KeyError` to be thrown, then don't pass 
the `default_var` argument. 
 
+### Removal of `airflow_home` config setting
+
+There were previously two ways of specifying the Airflow "home" directory
+(`~/airflow` by default): the `AIRFLOW_HOME` environment variable, and the
+`airflow_home` config setting in the `[core]` section.
+
+If they had two different values different parts of the code base would end up
+with different values. The config setting has been deprecated, and you should
+remove the value form the config files and set `AIRFLOW_HOME` environment
+variable if you need to use a non default value for this.
+
+(Since this setting is used to calculate what config file to load, it is not
+possible to keep just the config option)
 
 Review comment:
   Having re-read this: this is the very problem I ran in to that caused me to 
issue the PR. If the are set to different values then the webserver_config.py 
would be looked for in one, but other things from the other.
   
   Specifically the problem I had was that webserver_config.py was written to 
one, but read from the other! So `airflow create_user` etc targeted an 
`sqlite://:memory:` DB!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to