potiuk commented on a change in pull request #13371:
URL: https://github.com/apache/airflow/pull/13371#discussion_r550284307
##########
File path: airflow/upgrade/rules/airflow_macro_plugin_removed.py
##########
@@ -39,9 +39,16 @@ def _check_file(self, file_path):
problems = []
class_name_to_check = self.MACRO_PLUGIN_CLASS.split(".")[-1]
with open(file_path, "r") as file_pointer:
- for line_number, line in enumerate(file_pointer, 1):
- if class_name_to_check in line:
- problems.append(self._change_info(file_path, line_number))
+ try:
+ for line_number, line in enumerate(file_pointer, 1):
+ if class_name_to_check in line:
+ problems.append(self._change_info(file_path,
line_number))
+ except UnicodeDecodeError:
+ raise Exception(
+ "Unable to read file {}, it may need to be added to the
.airflowignore".format(
Review comment:
Ah ok. Then if it a that stage, that might be a bit more complex, but
just a bit. Simply exclude upgrade_check tests + upgrade_check sources in those
two pre-commit checks (they already contain some exclusions):
https://github.com/apache/airflow/blob/748d05f519c0e5427d2a46763591f03697c4d585/.pre-commit-config.yaml#L266
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
