madison-ookla commented on a change in pull request #13371:
URL: https://github.com/apache/airflow/pull/13371#discussion_r552162168
##########
File path: airflow/upgrade/rules/airflow_macro_plugin_removed.py
##########
@@ -39,9 +39,16 @@ def _check_file(self, file_path):
problems = []
class_name_to_check = self.MACRO_PLUGIN_CLASS.split(".")[-1]
with open(file_path, "r") as file_pointer:
- for line_number, line in enumerate(file_pointer, 1):
- if class_name_to_check in line:
- problems.append(self._change_info(file_path, line_number))
+ try:
+ for line_number, line in enumerate(file_pointer, 1):
+ if class_name_to_check in line:
+ problems.append(self._change_info(file_path,
line_number))
+ except UnicodeDecodeError:
+ raise Exception(
+ "Unable to read file {}, it may need to be added to the
.airflowignore".format(
Review comment:
Just want to check back in on this @potiuk @turbaszek @dimberman - we
can make the upgrade check Python 3.6+ (or even just the tests Py3.6+ if we'd
like), but currently the package still supports 2.7
(https://github.com/apache/airflow/blob/v1-10-stable/airflow/upgrade/setup.cfg#L35).
Should we bump up these requirements to 3.6? I agree that it makes sense to do
so, since this is a utility for upgrading to Airflow 2.0 which is 3.6+.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
