mik-laj commented on a change in pull request #13409: URL: https://github.com/apache/airflow/pull/13409#discussion_r552412153
########## File path: scripts/docker/install_airflow.sh ########## @@ -0,0 +1,68 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Install airflow using regular 'pip install' command. This install airflow depending on the arguments: +# AIRFLOW_INSTALLATION_METHOD - determines where to install airflow form: +# "." - installs airflow from local sources +# "apache-airflow" - installs airflow from PyPI 'apache-airflow' package +# AIRFLOW_INSTALL_VERSION - optionally specify version to install +# UPGRADE_TO_NEWER_DEPENDENCIES - determines whether eager-upgrade should be performed with the +# dependencies (with EAGER_UPGRADE_ADDITIONAL_REQUIREMENTS added) +# In all cases +# If UPGRADE_TO_NEWER_DEPENDENCIES is set to true, +# shellcheck disable=SC2086 Review comment: ```suggestion # shellcheck disable=SC2086 test -v AIRFLOW_INSTALLATION_METHOD test -v AIRFLOW_INSTALL_EDITABLE_FLAG test -v AIRFLOW_INSTALL_USER_FLAG test -v INSTALL_MYSQL_CLIENT test -v UPGRADE_TO_NEWER_DEPENDENCIES test -v CONTINUE_ON_PIP_CHECK_FAILURE test -v AIRFLOW_CONSTRAINTS_LOCATION ``` Extra sanity checks ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
