mik-laj commented on a change in pull request #13409: URL: https://github.com/apache/airflow/pull/13409#discussion_r552412530
########## File path: scripts/docker/install_airflow_from_latest_master.sh ########## @@ -0,0 +1,43 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# shellcheck disable=SC2086 + +# Installs Airflow from latest master. This is pure optimisation. It is done because we do not want +# to reinstall all dependencies from scratch when setup.py changes. Problem with Docker caching is that +# when a file is changed, when added to docker context, it invalidates the cache and it causes Docker +# build to reinstall all dependencies from scratch. This can take a loooooot of time. Therefore we install +# the dependencies first from master (and uninstall airflow right after) so that we can start installing +# deps from those pre-installed dependencies. It saves few minutes of build time when setup.py changes. +# +# If INSTALL_MYSQL_CLIENT is set to false, mysql extra is removed +# +function install_airflow_from_latest_master() { Review comment: ```suggestion test -v INSTALL_MYSQL_CLIENT test -v AIRFLOW_INSTALL_USER_FLAG test -v AIRFLOW_REPO test -v AIRFLOW_BRANCH test -v AIRFLOW_CONSTRAINTS_LOCATION test -v AIRFLOW_PIP_VERSION function install_airflow_from_latest_master() { ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
