dstandish commented on a change in pull request #13423:
URL: https://github.com/apache/airflow/pull/13423#discussion_r553117912
##########
File path: airflow/operators/bash_operator.py
##########
@@ -20,7 +20,7 @@
import warnings
# pylint: disable=unused-import
-from airflow.operators.bash import STDOUT, BashOperator, Popen, gettempdir #
noqa
+from airflow.operators.bash import BashOperator # noqa
Review comment:
@ashb @turbaszek are you sure these imports really need to be preserved?
you could make the same argument about [these
lines](https://github.com/apache/airflow/pull/13423/files#diff-912cc49726a411fd88f68b771c1de66996acd9b68c7e0e6b2e0caa7d8b23a188L21-L23).
or any time you remove an import from a module
users probably shouldn't be importing Popen from `bash_operator` anyway...
WDYT?
if you think these left in, with deprecation warning, please also comment
with guidance on the same issue for `airflow.operators.bash`
I've left it as is for now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
