dstandish commented on a change in pull request #13423: URL: https://github.com/apache/airflow/pull/13423#discussion_r552064653
########## File path: airflow/hooks/bash.py ########## @@ -0,0 +1,88 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import os +import signal +from subprocess import PIPE, STDOUT, Popen +from tempfile import TemporaryDirectory, gettempdir +from typing import Dict, Optional + +from airflow import AirflowException +from airflow.hooks.base import BaseHook + + +class BashHook(BaseHook): + """Hook for running bash commands""" + + def __init__(self) -> None: + self.sub_process = None + super().__init__() + + def run_command(self, command, env: Optional[Dict[str, str]] = None, output_encoding: str = 'utf-8'): + """ + Execute the bash command in a temporary directory which will be cleaned afterwards + + If ``env`` is not supplied, ``os.environ`` is passed + + :param command: the bash command to run + :param env: Optional dict containing environment variables to be made available to the shell + environment in which ``command`` will be executed. If omitted, ``os.environ`` will be used. + :param output_encoding: encoding to use for decoding stdout + :return: last line of stdout + """ + self.log.info('Tmp dir root location: \n %s', gettempdir()) + + with TemporaryDirectory(prefix='airflowtmp') as tmp_dir: + + def pre_exec(): + # Restore default signal disposition and invoke setsid + for sig in ('SIGPIPE', 'SIGXFZ', 'SIGXFSZ'): + if hasattr(signal, sig): + signal.signal(getattr(signal, sig), signal.SIG_DFL) + os.setsid() + + self.log.info('Running command: %s', command) + + self.sub_process = Popen( # pylint: disable=subprocess-popen-preexec-fn + ['bash', "-c", command], + stdout=PIPE, + stderr=STDOUT, + cwd=tmp_dir, + env=env or os.environ, Review comment: good point. what do you think is better: * not touch env at all in the hook * pass `os.environ` only if `env is None` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
