kaxil opened a new pull request #13662:
URL: https://github.com/apache/airflow/pull/13662


   When a dag file is executed via Dag File Processors and multiple callbacks 
are
   created either via zombies or executor events, the dag file is added to
   the _file_path_queue and the manager will launch a new process to
   process it, which it should not since the dag file is currently under
   processing. This will bypass the _parallelism eventually especially when
   it takes long time to process some dag files.
   
   This address the same issue as https://github.com/apache/airflow/pull/11875
   but instead does not exlucde filepaths that are recently processed and that
   run at limit (which is only used in tests) when Callbacks are sent by the
   Agent. This is by design as execution of Callbacks is critical. This is done
   with a caveat to avoid duplicate processor -- i.e. if a processor exists,
   instead of removing the file path from the queue it is removed from the
   beginning of the queue to the end. This means that the processor with
   the filepath to run callback is still run before other filepaths are added.
   
   Tests are added to check the same.
   
   closes https://github.com/apache/airflow/issues/13047
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to