kaxil commented on a change in pull request #13662:
URL: https://github.com/apache/airflow/pull/13662#discussion_r557648539
##########
File path: tests/utils/test_dag_processing.py
##########
@@ -142,6 +142,72 @@ def test_max_runs_when_no_files(self):
child_pipe.close()
parent_pipe.close()
+ @pytest.mark.backend("mysql", "postgres")
+ def test_start_new_processes_with_same_filepath(self):
+ """
+ Test that when a processor already exist with a filepath, a new
processor won't be created
+ with that filepath. The filepath will just be removed from the list.
+ """
+ manager = DagFileProcessorManager(
+ dag_directory='directory',
+ max_runs=1,
+ processor_factory=MagicMock().return_value,
+ processor_timeout=timedelta.max,
+ signal_conn=MagicMock(),
+ dag_ids=[],
+ pickle_dags=False,
+ async_mode=True,
+ )
+
+ file_1 = 'file_1.py'
+ file_2 = 'file_2.py'
+ file_3 = 'file_3.py'
+ manager._file_path_queue = [file_1, file_2, file_3]
+
+ manager._processors[file_1] = MagicMock()
+ manager.start_new_processes()
+
+ assert file_1 in manager._processors.keys()
+ assert file_2 in manager._processors.keys()
+ assert [file_3] == manager._file_path_queue
Review comment:
@ashb Updated in
https://github.com/apache/airflow/pull/13662/commits/b7fd3749d2db2ff8edc12fecec2cb7f6534a0e5f
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
