mik-laj commented on a change in pull request #13735:
URL: https://github.com/apache/airflow/pull/13735#discussion_r562037474
##########
File path: chart/README.md
##########
@@ -366,6 +366,17 @@ helm install airflow . \
--set data.brokerUrl=redis://redis-user:password@redis-host:6379/0
```
+## Using additional containers
+
+If you are using your own sidecar container, you can add it through the
`extraContainers` value. You can define different containers for scheduler,
webserver and worker pods. For example, a sidecar that syncs DAGs from object
storage.
+
+```bash
Review comment:
Concrete examples are very helpful, especially since file syncing is a
very common case in Airflow. If we use specific examples, we should check if
they really work.
##########
File path: chart/README.md
##########
@@ -366,6 +366,17 @@ helm install airflow . \
--set data.brokerUrl=redis://redis-user:password@redis-host:6379/0
```
+## Using additional containers
+
+If you are using your own sidecar container, you can add it through the
`extraContainers` value. You can define different containers for scheduler,
webserver and worker pods. For example, a sidecar that syncs DAGs from object
storage.
+
+```bash
Review comment:
Specific examples are very helpful, especially since file syncing is a
very common case in Airflow. If we use specific examples, we should check if
they really work.
##########
File path: chart/templates/workers/worker-deployment.yaml
##########
@@ -214,6 +214,9 @@ spec:
{{- include "custom_airflow_environment" . | indent 10 }}
{{- include "standard_airflow_environment" . | indent 10 }}
{{- end }}
+{{- if .Values.workers.extraContainers }}
+{{- toYaml .Values.workers.extraContainers | nindent 8 }}
Review comment:
For now, we can only limit ourselves to Celery Executor, but I think it
is worth adding an entry in the documentation for this limitation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
