TobKed commented on a change in pull request #12814:
URL: https://github.com/apache/airflow/pull/12814#discussion_r563719826
##########
File path: airflow/providers/google/cloud/operators/dataflow.py
##########
@@ -43,6 +48,214 @@ class CheckJobRunning(Enum):
WaitForRun = 3
+class DataflowConfiguration(metaclass=ABCMeta):
+ """Abstract class for Dataflow configuration to be passed to Beam
operators"""
+
+ template_fields = ["job_name", "location"]
+
+ def __init__(
+ self,
+ *,
+ job_name: Optional[str] = "{{task.task_id}}",
+ append_job_name: bool = True,
+ project_id: Optional[str] = None,
+ location: Optional[str] = DEFAULT_DATAFLOW_LOCATION,
+ gcp_conn_id: str = "google_cloud_default",
+ delegate_to: Optional[str] = None,
+ poll_sleep: int = 10,
+ impersonation_chain: Optional[Union[str, Sequence[str]]] = None,
+ drain_pipeline: bool = False,
+ cancel_timeout: Optional[int] = 5 * 60,
+ wait_until_finished: Optional[bool] = None,
+ ) -> None:
+ self.job_name = job_name
+ self.append_job_name = append_job_name
+ self.project_id = project_id
+ self.location = location
+ self.gcp_conn_id = gcp_conn_id
+ self.delegate_to = delegate_to
+ self.poll_sleep = poll_sleep
+ self.impersonation_chain = impersonation_chain
+ self.drain_pipeline = drain_pipeline
+ self.cancel_timeout = cancel_timeout
+ self.wait_until_finished = wait_until_finished
+
+
+class DataflowPythonConfiguration(DataflowConfiguration):
Review comment:
Sure. As i mentioned
[here](https://github.com/apache/airflow/pull/12814#discussion_r563718589) I
made only base version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
